Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template, library pack generation #7533

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Fix template, library pack generation #7533

merged 1 commit into from
Jun 16, 2021

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Jun 16, 2021

  • Library and Template packs should consume/install the nupkg itself, instead of contents.
  • Fix the template packs install directory

@joeloff joeloff requested a review from wli3 June 16, 2021 04:11
@joeloff
Copy link
Member Author

joeloff commented Jun 16, 2021

@wli3, @mhutch per the workload manifest spec, https://github.com/dotnet/designs/blob/main/accepted/2020/workloads/workload-manifest.md#template-packs, the install directory should be "template-packs". Can you confirm if that is still accurate?

@wli3
Copy link

wli3 commented Jun 16, 2021 •
edited
Loading

@joeloff correct. Existing template folder is used for non workload templates

@joeloff joeloff merged commit 6f94f31 into dotnet:main Jun 16, 2021
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wli3 wli3 wli3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeloff @wli3